Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 196573021: Remove testRunner.display calls from table border collapsing tests (Closed)

Created:
6 years, 9 months ago by jamesr
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Remove testRunner.display calls from table border collapsing tests Tables cache data related to border collapsing to optimize paint calls as the border collapsing logic can be slow. These layout tests make sure that we correctly invalidate and recompute this cache in response to various style/DOM changes, so they need to run some code to set up the scene, go through the paint path to set up the cache, then invalidate the cache by causing further mutations. This uses the runAfterDisplay harness to run the second part of the test after painting instead of invoking testRunner.display() directly. Since the table border collapsing logic doesn't directly involve repaint invalidations, this doesn't attempt to preserve the invalidation data. Invalidations on table changes should be covered by other tests. BUG=345027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -67 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +17 lines, -0 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-69296.html View 2 chunks +13 lines, -12 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-cell-append.html View 1 chunk +11 lines, -7 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-cell-remove.html View 1 chunk +8 lines, -4 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-cell-border-color.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html View 1 chunk +8 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color.html View 2 chunks +12 lines, -8 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-col-border-color.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-col-border-width.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-color.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-width.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-row-border-color.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-row-border-width.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-table-border-color.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-table-border-width.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-color.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width.html View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
Recommended listening: http://www.youtube.com/watch?v=imamcajBEJs
6 years, 9 months ago (2014-03-15 01:24:38 UTC) #1
enne (OOO)
lgtm
6 years, 9 months ago (2014-03-17 17:34:23 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 9 months ago (2014-03-17 17:41:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/196573021/1
6 years, 9 months ago (2014-03-17 17:41:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:44:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-17 17:44:17 UTC) #6
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 9 months ago (2014-03-17 17:45:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/196573021/1
6 years, 9 months ago (2014-03-17 17:46:08 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 18:22:36 UTC) #9
Message was sent while issue was closed.
Change committed as 169378

Powered by Google App Engine
This is Rietveld 408576698