|
Remove testRunner.display calls from table border collapsing tests
Tables cache data related to border collapsing to optimize paint calls
as the border collapsing logic can be slow. These layout tests make
sure that we correctly invalidate and recompute this cache in response
to various style/DOM changes, so they need to run some code to set up
the scene, go through the paint path to set up the cache, then
invalidate the cache by causing further mutations. This uses the
runAfterDisplay harness to run the second part of the test after
painting instead of invoking testRunner.display() directly.
Since the table border collapsing logic doesn't directly involve
repaint invalidations, this doesn't attempt to preserve the
invalidation data. Invalidations on table changes should be covered by
other tests.
BUG= 345027
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169378
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+146 lines, -67 lines) |
Patch |
 |
M |
LayoutTests/TestExpectations
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-69296.html
|
View
|
|
2 chunks |
+13 lines, -12 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-cell-append.html
|
View
|
|
1 chunk |
+11 lines, -7 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-cell-remove.html
|
View
|
|
1 chunk |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-cell-border-color.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-cell-border-width.html
|
View
|
|
1 chunk |
+8 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-cell-sl-border-color.html
|
View
|
|
2 chunks |
+12 lines, -8 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-col-border-color.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-col-border-width.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-color.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-colgroup-border-width.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-row-border-color.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-row-border-width.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-table-border-color.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-table-border-width.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-color.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width.html
|
View
|
|
1 chunk |
+7 lines, -3 lines |
0 comments
|
Download
|
Total messages: 9 (0 generated)
|