Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 196573017: Fix Telemetry pinch speed parameter passing. (Closed)

Created:
6 years, 9 months ago by e.hakkinen
Modified:
6 years, 9 months ago
Reviewers:
Dominik Grewe, bulach, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix Telemetry pinch speed parameter passing. Fixes Telemetry to properly pass also the pinch speed parameter to a browser provided benchmarking function. BUG=352583 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
e.hakkinen
The CQ bit was unchecked by e.hakkinen@partner.samsung.com
6 years, 9 months ago (2014-03-14 11:31:25 UTC) #1
e.hakkinen
The CQ bit was checked by e.hakkinen@partner.samsung.com
6 years, 9 months ago (2014-03-14 11:31:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@partner.samsung.com/196573017/1
6 years, 9 months ago (2014-03-14 11:31:28 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 11:31:29 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-14 11:31:30 UTC) #5
Dominik Grewe
Thanks for the fix. LGTM. You also need an LGTM from an owner before you ...
6 years, 9 months ago (2014-03-14 11:36:09 UTC) #6
bulach
hi! Thanks for the patch! I think you also need to follow the process: http://dev.chromium.org/developers/contributing-code/external-contributor-checklist ...
6 years, 9 months ago (2014-03-14 14:09:54 UTC) #7
e.hakkinen
On 2014/03/14 14:09:54, bulach wrote: > I think you also need to follow the process: ...
6 years, 9 months ago (2014-03-17 08:37:54 UTC) #8
e.hakkinen
On 2014/03/17 08:37:54, e.hakkinen wrote: > On 2014/03/14 14:09:54, bulach wrote: > > if you ...
6 years, 9 months ago (2014-03-24 09:27:36 UTC) #9
bulach
lgtm, thanks! sorry about the delay, I just confirmed your address is now listed in ...
6 years, 9 months ago (2014-03-24 10:51:06 UTC) #10
e.hakkinen
The CQ bit was checked by e.hakkinen@partner.samsung.com
6 years, 9 months ago (2014-03-24 11:06:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@partner.samsung.com/196573017/1
6 years, 9 months ago (2014-03-24 11:06:18 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 13:23:21 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-24 13:23:22 UTC) #14
e.hakkinen
The CQ bit was checked by e.hakkinen@partner.samsung.com
6 years, 9 months ago (2014-03-24 15:44:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@partner.samsung.com/196573017/1
6 years, 9 months ago (2014-03-24 15:44:40 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 18:08:07 UTC) #17
Message was sent while issue was closed.
Change committed as 258968

Powered by Google App Engine
This is Rietveld 408576698