Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1965713003: media: Fix gn deps on media/audio/* targets (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/audio/* targets Add some needed dependencies. BUG=599578 TEST=gn check //media/audio/* is clean Committed: https://crrev.com/d84a72067b279a3003783c9ed884452c20ecfd29 Cr-Commit-Position: refs/heads/master@{#393149}

Patch Set 1 #

Patch Set 2 : use //media to avoid Windows issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M media/audio/BUILD.gn View 1 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
jrummell
PTAL. Just working my way through the media directory cleaning up the GN files.
4 years, 7 months ago (2016-05-10 17:25:10 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 7 months ago (2016-05-10 17:46:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965713003/1
4 years, 7 months ago (2016-05-10 18:16:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/19455)
4 years, 7 months ago (2016-05-10 21:08:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965713003/20001
4 years, 7 months ago (2016-05-12 01:05:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 02:11:24 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 02:14:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d84a72067b279a3003783c9ed884452c20ecfd29
Cr-Commit-Position: refs/heads/master@{#393149}

Powered by Google App Engine
This is Rietveld 408576698