Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965693002: Fix null crash when creating KeyframeEffects with null targets (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null crash when creating KeyframeEffects with null targets BUG=607082 Committed: https://crrev.com/854ebb61d6015583d1d3650147390be006725cd2 Cr-Commit-Position: refs/heads/master@{#392600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/animations/keyframe-effect-null-target-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
alancutter (OOO until 2018)
4 years, 7 months ago (2016-05-10 07:41:39 UTC) #2
Eric Willigers
lgtm
4 years, 7 months ago (2016-05-10 13:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965693002/1
4 years, 7 months ago (2016-05-10 13:41:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 14:40:16 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 14:41:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/854ebb61d6015583d1d3650147390be006725cd2
Cr-Commit-Position: refs/heads/master@{#392600}

Powered by Google App Engine
This is Rietveld 408576698