Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1965653003: [turbofan] Also disable concurrent recompilation when tracing TurboFan. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also disable concurrent recompilation when tracing TurboFan. Treat --trace-turbo and --trace-turbo-graph similar to --trace-hydrogen and --trace-hydrogen-stubs, in that we disable concurrent recompilation in that case (otherwise we cannot print heap objects and stuff). R=ishell@chromium.org BUG=v8:4969 LOG=n Committed: https://crrev.com/82de25f00852d25d17174be5ab746d5367561565 Cr-Commit-Position: refs/heads/master@{#36123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-10 07:29:31 UTC) #1
Igor Sheludko
lgtm
4 years, 7 months ago (2016-05-10 07:30:08 UTC) #2
Benedikt Meurer
Hey Igor, This makes --trace-turbo and --trace-turbo-graph work again. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-10 07:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965653003/1
4 years, 7 months ago (2016-05-10 07:30:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 07:56:42 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 07:56:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82de25f00852d25d17174be5ab746d5367561565
Cr-Commit-Position: refs/heads/master@{#36123}

Powered by Google App Engine
This is Rietveld 408576698