[Offline Pages] Introducing StorageManagerClient interface.

components/offline_pages/offline_page_model.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <set>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "base/optional.h"
 #include "base/supports_user_data.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/offline_pages/offline_page_archiver.h"
 #include "components/offline_pages/offline_page_metadata_store.h"
+#include "components/offline_pages/offline_page_storage_manager.h"
 #include "components/offline_pages/offline_page_types.h"
 
 class GURL;
 namespace base {
 class SequencedTaskRunner;
 class Time;
 class TimeDelta;
 class TimeTicks;
 }
 
@@ skipping 19 matching lines @@
 //     ...
 //   }
 //
 //   // In code using the OfflinePagesModel to save a page:
 //   std::unique_ptr<ArchiverImpl> archiver(new ArchiverImpl());
 //   // Callback is of type SavePageCallback.
 //   model->SavePage(url, std::move(archiver), callback);
 //
 // TODO(fgorski): Things to describe:
 // * how to cancel requests and what to expect
-class OfflinePageModel : public KeyedService, public base::SupportsUserData {
+class OfflinePageModel : public KeyedService,
+                         public base::SupportsUserData,
+                         public OfflinePageStorageManager::Client {
  public:
   // Observer of the OfflinePageModel.
   class Observer {
    public:
     // Invoked when the model has finished loading.
     virtual void OfflinePageModelLoaded(OfflinePageModel* model) = 0;
 
     // Invoked when the model is being updated, due to adding, removing or
     // updating an offline page.
     virtual void OfflinePageModelChanged(OfflinePageModel* model) = 0;
@@ skipping 44 matching lines @@
   // Marks that the offline page related to the passed |offline_id| has been
   // accessed. Its access info, including last access time and access count,
   // will be updated. Requires that the model is loaded.
   void MarkPageAccessed(int64_t offline_id);
 
   // Deletes an offline page related to the passed |offline_id|.
   void DeletePageByOfflineId(int64_t offline_id,
                              const DeletePageCallback& callback);
 
   // Deletes offline pages related to the passed |offline_ids|.
-  // Making virtual for test purposes.
-  virtual void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
-                                      const DeletePageCallback& callback);
+  void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,
+                              const DeletePageCallback& callback) override;
 
   // Wipes out all the data by deleting all saved files and clearing the store.
   void ClearAll(const base::Closure& callback);
 
   // Deletes offline pages matching the URL predicate.
   void DeletePagesByURLPredicate(const UrlPredicate& predicate,
                                  const DeletePageCallback& callback);
 
   // Returns true via callback if there are offline pages in the given
   // |name_space|.
   void HasPages(const std::string& name_space,
                 const HasPagesCallback& callback);
 
   // Returns via callback all GURLs in |urls| that are equal to the online URL
   // of any offline page.
   void CheckPagesExistOffline(const std::set<GURL>& urls,
                               const CheckPagesExistOfflineCallback& callback);
 
   // Gets all available offline pages.
-  // Making virtual for test purposes.
-  virtual void GetAllPages(const MultipleOfflinePageItemCallback& callback);
+  void GetAllPages(const MultipleOfflinePageItemCallback& callback) override;
 
   // Gets all offline ids where the offline page has the matching client id.
   void GetOfflineIdsForClientId(const ClientId& client_id,
                                 const MultipleOfflineIdCallback& callback);
 
   // Gets all offline ids where the offline page has the matching client id.
   // Requires that the model is loaded.  May not return matching IDs depending
   // on the internal state of the model.
   //
   // This function is deprecated.  Use |GetOfflineIdsForClientId| instead.
@@ skipping 50 matching lines @@
   // deleted. In the latter case |reporting_after_delete| is set to true.
   // Caller is supposed to provide the current |total_space_bytes| on drive
   // where the pages are stored, as well as |free_space_bytes| after the
   // operation was taken. The method will report total size of all pages, and
   // percentage of size of pages as compared to total space and free space.
   void RecordStorageHistograms(int64_t total_space_bytes,
                                int64_t free_space_bytes,
                                bool reporting_after_delete);
 
   // Returns the policy controller.
-  // Making virtual for test purposes.
-  virtual ClientPolicyController* GetPolicyController();
+  ClientPolicyController* GetPolicyController();
 
   // Methods for testing only:
   OfflinePageMetadataStore* GetStoreForTesting();
 
   OfflinePageStorageManager* GetStorageManager();
 
-  // Making virtual for test purposes.
-  virtual bool is_loaded() const;
+  bool is_loaded() const;
 
  protected:
   // Adding a protected constructor for testing-only purposes in
   // offline_page_storage_manager_unittest.cc
   OfflinePageModel();
 
  private:
   FRIEND_TEST_ALL_PREFIXES(OfflinePageModelTest, MarkPageForDeletion);
 
   typedef ScopedVector<OfflinePageArchiver> PendingArchivers;
@@ skipping 123 matching lines @@
   std::unique_ptr<OfflinePageStorageManager> storage_manager_;
 
   base::WeakPtrFactory<OfflinePageModel> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageModel);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_