Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 196563003: Make Traversal<SVGElement> API a little bit more efficient (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Visibility:
Public.

Description

Make Traversal<SVGElement> API a little bit more efficient Make Traversal<SVGElement> API a little bit more efficient by specializing the following templated function for SVGElement: template <typename T> inline bool isElementOfType(const Node& node); It leverages the fact that Node has an IsSVGFlag flag and we can call Node::isSVGElement() directly on the input Node. Without this specialization, the default template implementation would do the following check: - node.isElementNode() && toElement(node).isSVGElement() We thus bypass the redundant Node::isElementNode() call. R=pdr BUG=346733 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/svg/SVGElement.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-03-20 22:15:00 UTC) #1
pdr.
On 2014/03/20 22:15:00, Chris Dumez wrote: LGTM
6 years, 9 months ago (2014-03-20 22:21:43 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-20 22:21:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/196563003/1
6 years, 9 months ago (2014-03-20 22:21:47 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 22:46:38 UTC) #5
Message was sent while issue was closed.
Change committed as 169703

Powered by Google App Engine
This is Rietveld 408576698