Fix Map::AsArray to properly iterate over the backing store

Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

This is the Map equivalent of commit 2d9bfe9ad5.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

R=cbruni@chromium.org
BUG=v8:4946
LOG=y

Committed: https://crrev.com/b767329b3704632229c88d9c6ea5b0dab28d4e37
Cr-Commit-Position: refs/heads/master@{#36149}

[Camillo Bruni, 2016-05-10 06:50:59]

LGTM with nit

https://codereview.chromium.org/1965593002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1965593002/diff/1/src/api.cc#newcode6376
src/api.cc:6376: if (key->IsTheHole()) continue;
nit: IsTheHole in a loop is rather slow, keep a local hole around for direct
comparison is a bit faster ;)

[adamk, 2016-05-10 17:16:42]

Description was changed from

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

Also micro-optimized to avoid an extra call to KeyAt().

This is the Map equivalent of commit 2d9bfe9ad5.

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

to

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

This is the Map equivalent of commit 2d9bfe9ad5.

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

[adamk, 2016-05-10 17:16:55]

Description was changed from

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

This is the Map equivalent of commit 2d9bfe9ad5.

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

to

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

This is the Map equivalent of commit 2d9bfe9ad5.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

[adamk, 2016-05-10 17:19:00]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-05-10 17:19:01]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1965593002/#ps20001
(title: "Micro-optimized")

[commit-bot: I haz the power, 2016-05-10 17:19:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965593002/20001

[adamk, 2016-05-10 17:19:24]

https://codereview.chromium.org/1965593002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1965593002/diff/1/src/api.cc#newcode6376
src/api.cc:6376: if (key->IsTheHole()) continue;
On 2016/05/10 06:50:59, Camillo Bruni wrote:
> nit: IsTheHole in a loop is rather slow, keep a local hole around for direct
> comparison is a bit faster ;)

Done, and added a DisallowHeapAllocation for good measure.

[commit-bot: I haz the power, 2016-05-10 18:05:33]

Description was changed from

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

This is the Map equivalent of commit 2d9bfe9ad5.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

to

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

This is the Map equivalent of commit 2d9bfe9ad5.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

[commit-bot: I haz the power, 2016-05-10 18:05:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 18:08:05]

Description was changed from

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

This is the Map equivalent of commit 2d9bfe9ad5.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

R=cbruni@chromium.org
BUG=v8:4946
LOG=y
==========

to

==========
Fix Map::AsArray to properly iterate over the backing store

Old code failed to walk over deleted elements, instead treating
deleted elements as "undefined" in the output array.

This is the Map equivalent of commit 2d9bfe9ad5.

Also micro-optimized the loops to avoid an extra call to KeyAt()
and used a direct hole comparison instead of calling IsTheHole().

R=cbruni@chromium.org
BUG=v8:4946
LOG=y

Committed: https://crrev.com/b767329b3704632229c88d9c6ea5b0dab28d4e37
Cr-Commit-Position: refs/heads/master@{#36149}
==========

[commit-bot: I haz the power, 2016-05-10 18:08:06]

Patchset 2 (id:??) landed as
https://crrev.com/b767329b3704632229c88d9c6ea5b0dab28d4e37
Cr-Commit-Position: refs/heads/master@{#36149}