Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: shell/native_runner_unittest.cc

Issue 1965563002: Neuter the wrong-way ServiceProvider (a.k.a. exposed_services). (Closed) Base URL: https://github.com/domokit/mojo.git@work795_js_wrong_way
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/context.cc ('k') | shell/shell_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/native_runner_unittest.cc
diff --git a/shell/native_runner_unittest.cc b/shell/native_runner_unittest.cc
index fe21447205ac0e6af879180e03ef29c08f00f553..6ab81aabb4a655d623de43adcf6c94738b0fe9dc 100644
--- a/shell/native_runner_unittest.cc
+++ b/shell/native_runner_unittest.cc
@@ -88,10 +88,8 @@ TEST_F(NativeApplicationLoaderTest, DoesNotExist) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));
GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
- mojo::InterfaceRequest<mojo::ServiceProvider> services;
- mojo::ServiceProviderPtr service_provider;
- application_manager_.ConnectToApplication(
- url, GURL(), services.Pass(), service_provider.Pass(), base::Closure());
+ application_manager_.ConnectToApplication(url, GURL(), nullptr,
+ base::Closure());
EXPECT_FALSE(state_.runner_was_created);
EXPECT_FALSE(state_.runner_was_started);
EXPECT_FALSE(state_.runner_was_destroyed);
« no previous file with comments | « shell/context.cc ('k') | shell/shell_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698