Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 1965553005: Async DNS: Don't watch hosts file on Android (Closed)

Created:
4 years, 7 months ago by Julia Tuttle
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Async DNS: Don't watch hosts file on Android The hosts file on Android should never change (it's on the read-only /system partition), and attempting to watch it also tries to watch /, which triggers a SELinux denial in Android N. Therefore, don't watch it on Android. BUG=600442 Review-Url: https://codereview.chromium.org/1906573002 Cr-Commit-Position: refs/heads/master@{#391799} (cherry picked from commit a2e7ea61ce75af85c4479c5af292383e3cf08341) Committed: https://chromium.googlesource.com/chromium/src/+/8118cdeafceca82dcff6e180ea9b35f674563fb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -30 lines) Patch
M net/dns/dns_config_service_posix.cc View 7 chunks +14 lines, -23 lines 0 comments Download
M net/dns/dns_config_service_posix_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Julia Tuttle
4 years, 7 months ago (2016-05-10 17:45:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8118cdeafceca82dcff6e180ea9b35f674563fb7.

Powered by Google App Engine
This is Rietveld 408576698