Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1965553004: Roll flac 2c4b86af:2d224742 (Closed)

Created:
4 years, 7 months ago by hans
Modified:
4 years, 7 months ago
Reviewers:
Nico, felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll flac 2c4b86af:2d224742 9fc1ca46 Update flac URL in README.chromium. 59c0c55a Update FLAC to 1.3.1 2d224742 README.chromium: restore the Name field BUG=610125 Committed: https://crrev.com/607364754c497842182a9c776e492564689d8d4f Cr-Commit-Position: refs/heads/master@{#392693}

Patch Set 1 #

Patch Set 2 : Pick up 2d22474 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
hans
Please take a look.
4 years, 7 months ago (2016-05-10 18:29:31 UTC) #3
felt
lgtm
4 years, 7 months ago (2016-05-10 18:40:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965553004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965553004/20001
4 years, 7 months ago (2016-05-10 18:42:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 20:11:47 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/607364754c497842182a9c776e492564689d8d4f Cr-Commit-Position: refs/heads/master@{#392693}
4 years, 7 months ago (2016-05-10 20:13:02 UTC) #10
Nico
As far as I can tell, this breaks liking on Windows: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/8652/steps/compile/logs/stdio Can you take ...
4 years, 7 months ago (2016-05-10 21:51:07 UTC) #12
hans
4 years, 7 months ago (2016-05-10 21:54:51 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1969573002/ by hans@chromium.org.

The reason for reverting is: Broke e.g.
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/8652/ste...

Reverting while investigating..

Powered by Google App Engine
This is Rietveld 408576698