third_party/WebKit/Source/core/editing/Editor.h - Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use SelectionModifier, rename RangeVector Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/Editor.h

diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h

index cf0ff43f65c7f7f0ad80bfb5f5fe5324f731af06..d9786692819dec713af664a5ca7ff0cc96916142 100644

--- a/third_party/WebKit/Source/core/editing/Editor.h

+++ b/third_party/WebKit/Source/core/editing/Editor.h

@@ -146,6 +146,10 @@ public:

return *m_frame;

}

+ // Returns target ranges for the command, currently only supports delete related commands.

+ // Used by InputEvent.

+ RangeVector* getRanges() const;

yosin_UTC9 2016/05/19 05:01:02 Let's use std::unique_ptr<RangeVector>

chongz 2016/05/25 05:38:57 Done.

const EditorInternalCommand* m_command;

EditorCommandSource m_source;

Member<LocalFrame> m_frame;