third_party/WebKit/Source/core/editing/InputMethodController.cpp - Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 1965543002: [InputEvent] Support |sequence<Range> getRanges()| in 'beforeinput' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ojan's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.h ('k') | third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp » ('j') | third_party/WebKit/Source/core/events/InputEvent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp

index bce455ebbcc63d4b2a2b92977150d405b19b892c..e7208bfed98cd17549b1a957c273e676db1b0197 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp

@@ -542,8 +542,9 @@ void InputMethodController::extendSelectionAndDelete(int before, int after)

break;

++before;

} while (frame().selection().start() == frame().selection().end() && before <= static_cast<int>(selectionOffsets.start()));

- // TODO(chongz): According to spec |data| should be "forward" or "backward".

- dispatchBeforeInputEditorCommand(frame().document()->focusedElement(), InputEvent::InputType::DeleteContent);

+ // TODO(chongz): New spec might want to change InputType.

+ // https://github.com/w3c/editing/issues/125#issuecomment-213041256

+ dispatchBeforeInputEditorCommand(m_frame->document()->focusedElement(), InputEvent::InputType::DeleteContent, emptyString(), new RangeVector(1, m_frame->selection().firstRange()));

TypingCommand::deleteSelection(*frame().document());

}