Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1965523002: SourceReport should test result of RestoreIcDataMap for NULL entries (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

SourceReport should test result of RestoreIcDataMap for NULL entries Entries in the result can't be the null object, but they can be NULL. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/87c4171b643d00910d963b03ae7e6acdd8cf7eb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/source_report.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years, 7 months ago (2016-05-09 20:52:19 UTC) #2
zra
4 years, 7 months ago (2016-05-09 21:16:36 UTC) #4
Cutch
lgtm
4 years, 7 months ago (2016-05-09 21:18:33 UTC) #5
zra
4 years, 7 months ago (2016-05-09 21:21:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
87c4171b643d00910d963b03ae7e6acdd8cf7eb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698