third_party/WebKit/Source/core/frame/Settings.in - Issue 1965493002: Add runtime setting to force passive event listeners.

Side by Side Diff: third_party/WebKit/Source/core/frame/Settings.in

Issue 1965493002: Add runtime setting to force passive event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/events/EventTarget.cpp ('K') | « third_party/WebKit/Source/core/frame/Settings.h ('k') | third_party/WebKit/Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 382 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
393 # The autoplay gesture override experiment is described in crbug.com/487345 .	393 # The autoplay gesture override experiment is described in crbug.com/487345 .

394 autoplayExperimentMode type=String, initial="off"	394 autoplayExperimentMode type=String, initial="off"

395	395

396 # When DevTools is emulating mobile device, frame resize may mean device size ha s changed,	396 # When DevTools is emulating mobile device, frame resize may mean device size ha s changed,

397 # which in turn affects media queries.	397 # which in turn affects media queries.

398 resizeIsDeviceSizeChange initial=false	398 resizeIsDeviceSizeChange initial=false

399	399

400 # Whether the browser process sends gesture events for wheel events.	400 # Whether the browser process sends gesture events for wheel events.

401 # Can be removed when crbug.com/598798 is fixed.	401 # Can be removed when crbug.com/598798 is fixed.

402 wheelGesturesEnabled initial=false	402 wheelGesturesEnabled initial=false

	403

	404 passiveListenerDefault type=PassiveListenerDefault, initial=PassiveListenerDefau lt::False
	Rick Byers 2016/05/09 21:48:48 nit: please add a comment. There's an effort to r nit: please add a comment. There's an effort to reduce the flags/settings, so it's valuable to explain what they're for / link to details. Maybe we'd say we can remove this once our intervention (and associated devtools features) ships? dtapuska 2016/05/11 20:01:10 Done. Show quoted text On 2016/05/09 21:48:48, Rick Byers wrote: > nit: please add a comment. There's an effort to reduce the flags/settings, so > it's valuable to explain what they're for / link to details. Maybe we'd say we > can remove this once our intervention (and associated devtools features) ships? Done.
OLD	NEW