Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196543004: make onReadPixels protected and have default impl (so we can remove chrome override) (Closed)

Created:
6 years, 9 months ago by reed2
Modified:
6 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

make onReadPixels protected and have default impl (so we can remove chrome override) TBR=bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=13756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M include/core/SkDevice.h View 2 chunks +11 lines, -11 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
step 2 is to change the signature to take raw pointers, like writePixels
6 years, 9 months ago (2014-03-12 02:49:29 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-12 02:49:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/196543004/1
6 years, 9 months ago (2014-03-12 02:49:40 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 03:04:10 UTC) #4
Message was sent while issue was closed. 
Change committed as 13756

Powered by Google App Engine
This is Rietveld 408576698