Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196543003: Remove modules/webdatabase dependency from core. (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, falken, dglazkov+blink, adamk+blink_chromium.org, Inactive, horo+watch_chromium.org, kinuko+watch, rwlbuis
Visibility:
Public.

Description

Remove modules/webdatabase dependency from core. This CL introduces ActiveDOMObject::willStop, and moves Web Database stuff in WorkerThread into DatabaseContext::willStop. BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M Source/core/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
6 years, 9 months ago (2014-03-12 02:33:54 UTC) #1
Hajime Morrita
lgtm. yay!
6 years, 9 months ago (2014-03-12 17:00:51 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-12 17:00:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/196543003/1
6 years, 9 months ago (2014-03-12 17:00:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 17:05:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit
6 years, 9 months ago (2014-03-12 17:05:15 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-12 21:50:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/196543003/1
6 years, 9 months ago (2014-03-12 21:50:27 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 02:03:05 UTC) #9
Message was sent while issue was closed. 
Change committed as 169068

Powered by Google App Engine
This is Rietveld 408576698