Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: runtime/vm/service/service.md

Issue 1965423003: Clarify definition of token position. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/service.md
diff --git a/runtime/vm/service/service.md b/runtime/vm/service/service.md
index e37643cba06cf0794e5963eb7efdcaf4cb365621..5463e0b2ddcfe19f86d8311e5ed0697782828cac 100644
--- a/runtime/vm/service/service.md
+++ b/runtime/vm/service/service.md
@@ -2216,6 +2216,10 @@ consists of a line number followed by _(tokenPos, columnNumber)_ pairs:
> [lineNumber, (tokenPos, columnNumber)*]
+The _tokenPos_ is an arbitrary integer value that is used to represent
+a location in the source code. A _tokenPos_ value is not meaningful
+in itself and code should not rely on the exact values returned.
+
For example, a _tokenPosTable_ with the value...
> [[1, 100, 5, 101, 8],[2, 102, 7]]
@@ -2523,5 +2527,5 @@ version | comments
3.2 | Isolate objects now include the runnable bit and many debugger related RPCs will return an error if executed on an isolate before it is runnable.
3.3 | Pause event now indicates if the isolate is paused at an await, yield, or yield* suspension point via the 'atAsyncSuspension' field. Resume command now supports the step parameter 'OverAsyncSuspension'. A Breakpoint added synthetically by an 'OverAsyncSuspension' resume command identifies itself as such via the 'isSyntheticAsyncContinuation' field.
3.4 | Add the superType and mixin fields to Class. Added new pause event 'None'.
-3.5 | Add the error field to SourceReportRange.
+3.5 | Add the error field to SourceReportRange. Clarify definition of token position.
[discuss-list]: https://groups.google.com/a/dartlang.org/forum/#!forum/observatory-discuss
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698