Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 1965413002: Disabling tests which were failing on Nexus 5X bot. (Closed)

Created:
4 years, 7 months ago by cblume
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling tests which were failing on Nexus 5X bot. The following tests were failing on the Nexus 5X so their tests were disabled: GpuProcess.no_gpu_process GpuProcess.skip_gpu_process GpuProcess.identify_active_gpu1 GpuProcess.identify_active_gpu2 GpuProcess.identify_active_gpu3 GpuProcess.identify_active_gpu4 GpuProcess.readback_webgl_gpu_process GpuProcess.driver_bug_workarounds_upon_gl_renderer Maps.maps_002 WebglExtension.EXT_sRGB WebglConformance.conformance_textures_misc_tex_image_and_sub_image_2d_with_array_buffer_view WebglConformance.conformance_textures_canvas_tex_2d_rgb_rgb_unsigned_byte WebglConformance.conformance_textures_canvas_tex_2d_rgb_rgb_unsigned_short_5_6_5 WebglConformance.conformance_textures_canvas_tex_2d_rgba_rgba_unsigned_byte WebglConformance.conformance_textures_canvas_tex_2d_rgba_rgba_unsigned_short_4_4_4_4 WebglConformance.conformance_textures_canvas_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 WebglConformance.conformance_textures_image_tex_2d_rgb_rgb_unsigned_short_5_6_5 WebglConformance.conformance_textures_image_tex_2d_rgba_rgba_unsigned_byte WebglConformance.conformance_textures_image_tex_2d_rgba_rgba_unsigned_short_4_4_4_4 WebglConformance.conformance_textures_image_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 BUG=409984, 610951 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1bbf35af60267e42dca191ac54abc2e04297585d Cr-Commit-Position: refs/heads/master@{#393048}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Formatting to fit in 80 chars. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M content/test/gpu/gpu_tests/gpu_process_expectations.py View 1 chunk +19 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/maps_expectations.py View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +32 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
cblume
https://codereview.chromium.org/1965413002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/1965413002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode109 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:109: 'conformance/textures/misc/tex-image-and-sub-image-2d-with-array-buffer-view.html', Note that this line and others marked with ...
4 years, 7 months ago (2016-05-11 15:15:55 UTC) #3
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/1965413002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/1965413002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode109 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:109: 'conformance/textures/misc/tex-image-and-sub-image-2d-with-array-buffer-view.html', On 2016/05/11 15:15:55, cblume wrote: > Note ...
4 years, 7 months ago (2016-05-11 17:43:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965413002/1
4 years, 7 months ago (2016-05-11 17:49:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/181371)
4 years, 7 months ago (2016-05-11 17:59:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965413002/20001
4 years, 7 months ago (2016-05-11 18:21:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 20:37:55 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 20:40:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bbf35af60267e42dca191ac54abc2e04297585d
Cr-Commit-Position: refs/heads/master@{#393048}

Powered by Google App Engine
This is Rietveld 408576698