Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19654003: Use explicit HTMLFrameElementBase cast (Closed)

Created:
7 years, 5 months ago by kangil_
Modified:
7 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use explicit HTMLFrameElementBase cast As <https://chromiumcodereview.appspot.com/19504005/diff/1/Source/core/rendering/RenderLayer.cpp#oldcode2247>; mentioned, it should be HTMLFrameElementBase that embraces both HTMLFrameElement and HTMLIFrameElement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kangil_
review please? :)
7 years, 5 months ago (2013-07-18 02:39:29 UTC) #1
tkent
lgtm Please add and apply toHTMLFrameElementBase() function later.
7 years, 5 months ago (2013-07-18 03:02:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19654003/1
7 years, 5 months ago (2013-07-18 03:03:14 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 04:34:56 UTC) #4
Message was sent while issue was closed. 
Change committed as 154469

Powered by Google App Engine
This is Rietveld 408576698