Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1965373002: Remove TypingResetter. (Closed)

Created:
4 years, 7 months ago by vogelheim
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove TypingResetter. This code was used exclusively by its own unit test and can be safely removed. BUG=v8:4947 LOG=N Committed: https://crrev.com/0bc5bf3a5974e9945d657d6d06fb7ed2ad88394d Cr-Commit-Position: refs/heads/master@{#36180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -353 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/typing-reset.h View 1 chunk +0 lines, -26 lines 0 comments Download
D src/typing-reset.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-typing-reset.cc View 1 chunk +0 lines, -297 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
vogelheim
4 years, 7 months ago (2016-05-11 13:58:10 UTC) #4
rossberg
lgtm
4 years, 7 months ago (2016-05-11 14:36:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965373002/1
4 years, 7 months ago (2016-05-11 14:47:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 14:48:54 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 14:49:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bc5bf3a5974e9945d657d6d06fb7ed2ad88394d
Cr-Commit-Position: refs/heads/master@{#36180}

Powered by Google App Engine
This is Rietveld 408576698