Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1965333002: Fix a memory error introduced by issue 1922083004, revealed by the (Closed)

Created:
4 years, 7 months ago by jkrcal
Modified:
4 years, 7 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a memory error introduced by issue 1922083004, revealed by the chromium.memory.fyi buildbot. BUG=603907 Committed: https://crrev.com/ffbe609f40c9df9523fc872d2fd1a71f22317064 Cr-Commit-Position: refs/heads/master@{#392921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/ntp_snippets_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jkrcal
PTAL.
4 years, 7 months ago (2016-05-11 11:26:32 UTC) #3
Marc Treib
lgtm
4 years, 7 months ago (2016-05-11 11:30:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965333002/1
4 years, 7 months ago (2016-05-11 14:02:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 14:41:08 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 14:43:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffbe609f40c9df9523fc872d2fd1a71f22317064
Cr-Commit-Position: refs/heads/master@{#392921}

Powered by Google App Engine
This is Rietveld 408576698