Issue 196533018: Remove EnableMemoryInfo WebSetting, rename internal to preciseMemoryInfoEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196533018: Remove EnableMemoryInfo WebSetting, rename internal to preciseMemoryInfoEnabled (Closed)

Created:
6 years, 9 months ago by mnaganov (inactive)

Modified:
6 years, 9 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove EnableMemoryInfo WebSetting, rename internal to preciseMemoryInfoEnabled As --enable-memory-info flag and web preference were removed from Chrome, remove the corresponding WebSetting. The internal setting is used by PerfTestRunner, so leave it, but rename to "preciseMemoryInfoEnabled" for clarity. BUG=350339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169434

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -11 lines)			Patch
M	PerformanceTests/resources/runner.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/Settings.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/timing/MemoryInfo.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebSettingsImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebSettings.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

The CQ bit was checked by mnaganov@chromium.org

6 years, 9 months ago (2014-03-18 08:45:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/196533018/1

6 years, 9 months ago (2014-03-18 08:46:04 UTC) #5

Message was sent while issue was closed.

Change committed as 169434

Expand Messages | Collapse Messages