Source/core/rendering/RenderEmbeddedObject.cpp - Issue 196533012: Make LayoutState always be RAII

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderEmbeddedObject.cpp

Issue 196533012: Make LayoutState always be RAII (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix FlexBox LayoutState scoping Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderEmbeddedObject.cpp

diff --git a/Source/core/rendering/RenderEmbeddedObject.cpp b/Source/core/rendering/RenderEmbeddedObject.cpp

index ff571188b5a3c5f095e7928fcb190ef81a4e7c78..4478a93842697f7e0457185d7582b327227d1547 100644

--- a/Source/core/rendering/RenderEmbeddedObject.cpp

+++ b/Source/core/rendering/RenderEmbeddedObject.cpp

@@ -238,8 +238,6 @@ void RenderEmbeddedObject::layout()

childBox->style()->setWidth(Length(newSize.width(), Fixed));

childBox->forceLayout();

clearNeedsLayout();

- statePusher.pop();

}

bool RenderEmbeddedObject::scroll(ScrollDirection direction, ScrollGranularity granularity, float)