Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/core/rendering/RenderVTTCue.cpp

Issue 196533012: Make LayoutState always be RAII (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated to ToT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTableSection.cpp ('k') | Source/core/rendering/RenderView.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Victor Carbune (victor@rosedu.org) 2 * Copyright (C) 2012 Victor Carbune (victor@rosedu.org)
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // have positioning information. 49 // have positioning information.
50 if (!m_cue->regionId().isEmpty()) 50 if (!m_cue->regionId().isEmpty())
51 return; 51 return;
52 52
53 LayoutStateMaintainer statePusher(*this, locationOffset()); 53 LayoutStateMaintainer statePusher(*this, locationOffset());
54 54
55 if (m_cue->snapToLines()) 55 if (m_cue->snapToLines())
56 repositionCueSnapToLinesSet(); 56 repositionCueSnapToLinesSet();
57 else 57 else
58 repositionCueSnapToLinesNotSet(); 58 repositionCueSnapToLinesNotSet();
59
60 statePusher.pop();
61 } 59 }
62 60
63 bool RenderVTTCue::findFirstLineBox(InlineFlowBox*& firstLineBox) 61 bool RenderVTTCue::findFirstLineBox(InlineFlowBox*& firstLineBox)
64 { 62 {
65 if (firstChild()->isRenderInline()) 63 if (firstChild()->isRenderInline())
66 firstLineBox = toRenderInline(firstChild())->firstLineBox(); 64 firstLineBox = toRenderInline(firstChild())->firstLineBox();
67 else 65 else
68 return false; 66 return false;
69 67
70 return true; 68 return true;
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 } 262 }
265 } 263 }
266 264
267 void RenderVTTCue::repositionCueSnapToLinesNotSet() 265 void RenderVTTCue::repositionCueSnapToLinesNotSet()
268 { 266 {
269 // FIXME: Implement overlapping detection when snap-to-lines is not set. htt p://wkb.ug/84296 267 // FIXME: Implement overlapping detection when snap-to-lines is not set. htt p://wkb.ug/84296
270 } 268 }
271 269
272 } // namespace WebCore 270 } // namespace WebCore
273 271
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableSection.cpp ('k') | Source/core/rendering/RenderView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698