Issue 196533007: Assert that allocation is allowed in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196533007: Assert that allocation is allowed in generated code. (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
5 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Assert that allocation is allowed in generated code. Allocation may happen in generated code as well, even though it has to call into runtime for GC. R=mstarzinger@chromium.org

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/execution.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

6 years, 9 months ago (2014-03-13 08:35:51 UTC) #2

This generally looks OK.

But as discussed offline: It currently fails a few tests because the restriction
is tighter than it needs to be. To get a finer grained coverage we just need to
run with Heap::DisableInlineAllocation() turned on and we will get better
assertion checking at the actual place of allocation.

Expand Messages | Collapse Messages