Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 196533005: skip unused value in CSSPropertyParser::parse2ValuesFillPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index d7c3cb58318ac707efb0c1d3bd380c28e69bae92..89f31400a1c047514cc60219657d6f2a1bcab1c2 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2692,8 +2692,6 @@ void CSSPropertyParser::parseFillPosition(CSSParserValueList* valueList, RefPtrW
void CSSPropertyParser::parse2ValuesFillPosition(CSSParserValueList* valueList, RefPtrWillBeRawPtr<CSSValue>& value1, RefPtrWillBeRawPtr<CSSValue>& value2)
{
- CSSParserValue* value = valueList->current();
-
// Parse the first value. We're just making sure that it is one of the valid keywords or a percentage/length.
unsigned cumulativeFlags = 0;
FillPositionFlag value1Flag = InvalidFillPosition;
@@ -2705,7 +2703,7 @@ void CSSPropertyParser::parse2ValuesFillPosition(CSSParserValueList* valueList,
// It only takes one value for background-position to be correctly parsed if it was specified in a shorthand (since we
// can assume that any other values belong to the rest of the shorthand). If we're not parsing a shorthand, though, the
// value was explicitly specified for our property.
- value = valueList->next();
+ CSSParserValue* value = valueList->next();
// First check for the comma. If so, we are finished parsing this value or value pair.
if (isComma(value))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698