Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 196533005: skip unused value in CSSPropertyParser::parse2ValuesFillPosition (Closed)

Created:
6 years, 9 months ago by Mostyn Bramley-Moore
Modified:
6 years, 9 months ago
Reviewers:
rwlbuis, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

skip unused value in CSSPropertyParser::parse2ValuesFillPosition Spotted a warning due to this unused value while testing some static analyzer tools. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@eseidel, Rob: PTAL at this trivial static analysis warning fix.
6 years, 9 months ago (2014-03-12 17:41:08 UTC) #1
rwlbuis
lgtm
6 years, 9 months ago (2014-03-12 17:43:09 UTC) #2
rwlbuis
lgtm
6 years, 9 months ago (2014-03-12 19:58:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/196533005/1
6 years, 9 months ago (2014-03-12 19:58:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 20:22:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_compile
6 years, 9 months ago (2014-03-12 20:22:05 UTC) #6
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 9 months ago (2014-03-12 22:07:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/196533005/1
6 years, 9 months ago (2014-03-12 22:07:50 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 02:04:09 UTC) #9
Message was sent while issue was closed.
Change committed as 169071

Powered by Google App Engine
This is Rietveld 408576698