Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1965293002: [turbofan] Unify function prototype constant folding. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify function prototype constant folding. Up until now we had two places where we did the function prototype folding, once in the Typer and once in JSTypedLowering. Put this logic into JSNativeContextSpecialization instead. R=jarin@chromium.org Committed: https://crrev.com/1270caeda48a61adf31a849f43346e58ef20217c Cr-Commit-Position: refs/heads/master@{#36157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -67 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-11 07:31:18 UTC) #1
Benedikt Meurer
Hey Jaro, Simple unification. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-11 07:31:54 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-11 07:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965293002/1
4 years, 7 months ago (2016-05-11 07:49:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 08:11:13 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:12:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1270caeda48a61adf31a849f43346e58ef20217c
Cr-Commit-Position: refs/heads/master@{#36157}

Powered by Google App Engine
This is Rietveld 408576698