Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965273005: Drop unnecessary media deps from content (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop unnecessary media deps from content R=jam@chromium.org BUG=608242 Committed: https://crrev.com/8047187f783191717da89f64b3bd677c3c728b78 Cr-Commit-Position: refs/heads/master@{#393324}

Patch Set 1 #

Patch Set 2 : Eliminate empty lists from DEPS #

Total comments: 2

Patch Set 3 : Add back //content/DEPS +media #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M content/app/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/media/capture/DEPS View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/speech/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/media/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/gpu/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/gpu/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/DEPS View 1 1 chunk +0 lines, -12 lines 0 comments Download
M content/shell/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/utility/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965273005/1
4 years, 7 months ago (2016-05-11 18:11:46 UTC) #2
Mark Dittmer
jam@chromium.org: PTAL at this follow-up from https://codereview.chromium.org/1882373004/#msg84
4 years, 7 months ago (2016-05-11 18:34:28 UTC) #3
Mark Dittmer
Eliminate empty lists from DEPS
4 years, 7 months ago (2016-05-11 18:41:28 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965273005/20001
4 years, 7 months ago (2016-05-11 18:42:03 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/227283)
4 years, 7 months ago (2016-05-11 20:25:17 UTC) #10
jam
https://codereview.chromium.org/1965273005/diff/20001/content/DEPS File content/DEPS (left): https://codereview.chromium.org/1965273005/diff/20001/content/DEPS#oldcode30 content/DEPS:30: "+media", why are you removing this one? what I ...
4 years, 7 months ago (2016-05-11 20:39:56 UTC) #11
Mark Dittmer
Add back //content/DEPS +media
4 years, 7 months ago (2016-05-12 15:00:31 UTC) #12
Mark Dittmer
https://codereview.chromium.org/1965273005/diff/20001/content/DEPS File content/DEPS (left): https://codereview.chromium.org/1965273005/diff/20001/content/DEPS#oldcode30 content/DEPS:30: "+media", On 2016/05/11 20:39:56, jam wrote: > why are ...
4 years, 7 months ago (2016-05-12 15:00:37 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965273005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965273005/40001
4 years, 7 months ago (2016-05-12 15:01:08 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 15:47:33 UTC) #17
jam
lgtm
4 years, 7 months ago (2016-05-12 15:57:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965273005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965273005/40001
4 years, 7 months ago (2016-05-12 19:09:46 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 19:13:44 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 19:15:36 UTC) #24
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8047187f783191717da89f64b3bd677c3c728b78
Cr-Commit-Position: refs/heads/master@{#393324}

Powered by Google App Engine
This is Rietveld 408576698