[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture layer.

[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org, tsepez@chromium.org

Committed: https://crrev.com/438b0447d618fdba716b5898422f7dea8fce472b
Cr-Commit-Position: refs/heads/master@{#393003}

[erikchen, 2016-05-11 02:07:40]

Description was changed from

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
==========

to

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-05-11 02:07:41]

Description was changed from

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-05-11 02:11:56]

Description was changed from

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org,
tsepez@chromium.org
==========

[erikchen, 2016-05-11 02:12:03]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 02:12:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965253002/20001

[erikchen, 2016-05-11 02:12:46]

erikchen@chromium.org changed reviewers:
+ bbudge@chromium.org, ccameron@chromium.org, piman@chromium.org,
sky@chromium.org, tsepez@chromium.org

[erikchen, 2016-05-11 02:12:47]

piman: Please review.

TBRing ccameron, bbudge, sky, tsepez.

[commit-bot: I haz the power, 2016-05-11 02:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 02:23:05]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[piman, 2016-05-11 02:35:25]

LGTM % typo

https://codereview.chromium.org/1965253002/diff/20001/gpu/ipc/service/gpu_cha...
File gpu/ipc/service/gpu_channel.cc (right):

https://codereview.chromium.org/1965253002/diff/20001/gpu/ipc/service/gpu_cha...
gpu/ipc/service/gpu_channel.cc:795: if ((stub && stub->HasUnprocesedCommands())
||
HasUnprocesedCommands->HasUnprocessedCommands
(2 ss's)

[erikchen, 2016-05-11 17:00:12]

https://codereview.chromium.org/1965253002/diff/20001/gpu/ipc/service/gpu_cha...
File gpu/ipc/service/gpu_channel.cc (right):

https://codereview.chromium.org/1965253002/diff/20001/gpu/ipc/service/gpu_cha...
gpu/ipc/service/gpu_channel.cc:795: if ((stub && stub->HasUnprocesedCommands())
||
On 2016/05/11 02:35:25, piman wrote:
> HasUnprocesedCommands->HasUnprocessedCommands
> (2 ss's)

I tested this on both ChromeOS, to make sure the fix worked, and flash video on
Mac. Then I reset my changes and rewrote the CL and apparently failed at
spelling.

[erikchen, 2016-05-11 17:00:17]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-05-11 17:00:18]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1965253002/#ps40001
(title: "Comments from piman.")

[commit-bot: I haz the power, 2016-05-11 17:00:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965253002/40001

[commit-bot: I haz the power, 2016-05-11 17:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 17:03:23]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[erikchen, 2016-05-11 17:24:47]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-05-11 17:24:48]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1965253002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-05-11 17:25:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965253002/60001

[Tom Sepez, 2016-05-11 17:33:23]

lgtm

[commit-bot: I haz the power, 2016-05-11 18:33:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-11 18:36:17]

Description was changed from

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org,
tsepez@chromium.org
==========

to

==========
[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture
layer.

This CL is a reland of two CLs:

Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from.
https://codereview.chromium.org/1951263003

[Reland 1] Pepper takes ownership of a mailbox before passing it to the texture
layer. https://codereview.chromium.org/1943513002

This CL fixes a logic error in GpuChannel where preemption was incorrectly
handled.

BUG=350204, 602484
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org,
tsepez@chromium.org

Committed: https://crrev.com/438b0447d618fdba716b5898422f7dea8fce472b
Cr-Commit-Position: refs/heads/master@{#393003}
==========

[commit-bot: I haz the power, 2016-05-11 18:36:19]

Patchset 4 (id:??) landed as
https://crrev.com/438b0447d618fdba716b5898422f7dea8fce472b
Cr-Commit-Position: refs/heads/master@{#393003}