Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1965243003: Revert of [wasm] Implement parallel compilation. (Closed)

Created:
4 years, 7 months ago by ahaas
Modified:
4 years, 7 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Implement parallel compilation. (patchset #6 id:100001 of https://codereview.chromium.org/1961973002/ ) Reason for revert: The ThreadSanitizer finds data races. Original issue's description: > [wasm] Implement parallel compilation. > > With this CL it is possible to compile a wasm module with multiple > threads in parallel. Parallel compilation works as follows: > > 1) The main thread allocates a compilation unit for each wasm function. > 2) The main thread spawns WasmCompilationTasks which run on the > background threads. > 3.a) The background threads and the main thread pick one compilation unit > at a time and execute the parallel phase of the compilation unit. > After finishing the execution of the parallel phase, the compilation > unit is stored in a result queue. > 3.b) If the result queue contains a compilation unit, the main thread > dequeues it and finishes its compilation. > 4) After the execution of the parallel phase of all compilation units has > started, the main thread waits for all WasmCompilationTasks to finish. > 5) The main thread finalizes the compilation of the module. > > I'm going to add some additional tests before committing this CL. > > R=titzer@chromium.org, bmeurer@chromium.org, mlippautz@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/17215438659d8ff2d7d55f95226bf8a1477ccd79 > Cr-Commit-Position: refs/heads/master@{#36178} TBR=bmeurer@chromium.org,mlippautz@chromium.org,mstarzinger@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/be8c688adee75ed028bff949c8ffe1077eea6229 Cr-Commit-Position: refs/heads/master@{#36182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -460 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 14 chunks +24 lines, -40 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 8 chunks +122 lines, -317 lines 0 comments Download
D test/mjsunit/wasm/parallel_compilation.js View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahaas
Created Revert of [wasm] Implement parallel compilation.
4 years, 7 months ago (2016-05-11 15:57:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965243003/1
4 years, 7 months ago (2016-05-11 15:58:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 15:58:13 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 15:59:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be8c688adee75ed028bff949c8ffe1077eea6229
Cr-Commit-Position: refs/heads/master@{#36182}

Powered by Google App Engine
This is Rietveld 408576698