Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965243002: Clean up CPDF_Color and some related code. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean up CPDF_Color and some related code. - Remove dead code in CPDF_Color. - Encapsulate member variables. - Added accessors as need. - Remove unused CPDF_ColorSpace::GetMaxIndex(). - Remove redundent CPDF_StreamContentParser::GetNumber16(). Committed: https://pdfium.googlesource.com/pdfium/+/a244dfe2ba2cc82ee264475253cc16222e022524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -67 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_color.cpp View 3 chunks +6 lines, -32 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 3 chunks +4 lines, -10 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_color.h View 2 chunks +5 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_colorspace.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-11 01:46:09 UTC) #3
Wei Li
lgtm
4 years, 7 months ago (2016-05-11 18:34:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965243002/1
4 years, 7 months ago (2016-05-11 19:58:57 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 19:59:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a244dfe2ba2cc82ee264475253cc16222e02...

Powered by Google App Engine
This is Rietveld 408576698