LayoutTests/fast/parser/xml-declaration-missing-ending-mark.html - Issue 196523007: Revert of id of iframe incorrectly sets window name

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/parser/xml-declaration-missing-ending-mark.html

Issue 196523007: Revert of id of iframe incorrectly sets window name (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0">	1 <?xml version="1.0">

2 <html xmlns="http://www.w3.org/1999/xhtml">	2 <html xmlns="http://www.w3.org/1999/xhtml">

3 <body>	3 <body>

4 <p>CRASH: Omitting terminal question mark in <?xml...?> declaration (above ) causes access violation.</p>	4 <p>CRASH: Omitting terminal question mark in <?xml...?> declaration (above ) causes access violation.</p>

5 <p>This tests the both the HTML parser (.html extension), which is where the cra sh was observed, and the XML	5 <p>This tests the both the HTML parser (.html extension), which is where the cra sh was observed, and the XML

6 parser (in an iframe).<br />	6 parser (in an iframe).<br />

7 See https://bugs.webkit.org/show_bug.cgi?id=17814</p>	7 See https://bugs.webkit.org/show_bug.cgi?id=17814</p>

8 <script>	8 <script>

9 if (window.testRunner) {	9 if (window.testRunner) {

10 testRunner.dumpAsText();	10 testRunner.dumpAsText();

11 testRunner.dumpChildFramesAsText();	11 testRunner.dumpChildFramesAsText();

12 }	12 }

13 </script>	13 </script>

14	14

15 <p>If you don't crash, you pass. A parsing error in the "xml-parser" subframe is expected.</p>	15 <p>If you don't crash, you pass. A parsing error in the "xml-parser" subframe is expected.</p>

16	16

17 <iframe name="xml-parser" src="resources/xml-declaration-missing-ending-mark.xml "></iframe>	17 <iframe id="xml-parser" src="resources/xml-declaration-missing-ending-mark.xml"> </iframe>

18 </body>	18 </body>

19 </html>	19 </html>

OLD	NEW