[DevTools]Abstract Counter and CounterUIBase

Source/devtools/front_end/MemoryStatistics.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
 
     // Populate sidebar
     this.sidebarElement().createChild("div", "sidebar-tree sidebar-tree-section").textContent = WebInspector.UIString("COUNTERS");
     this.createAllCounters();
 }
 
 /**
  * @constructor
  * @param {string} counterName
  */
-WebInspector.MemoryStatistics.Counter = function(counterName)
+WebInspector.Counter = function(counterName)
 {
     this.counterName = counterName;
     this.times = [];
     this.values = [];
 }
 
-WebInspector.MemoryStatistics.Counter.prototype = {
+WebInspector.Counter.prototype = {
     /**
      * @param {number} time
      * @param {!TimelineAgent.Counters} counters
      */
     appendSample: function(time, counters)
     {
         var value = counters[this.counterName];
         if (value === undefined)
             return;
         if (this.values.length && this.values.peekLast() === value)
@@ skipping 83 matching lines @@
     {
         this.checked = !this.checked;
         this.dispatchEventToListeners(WebInspector.SwatchCheckbox.Events.Changed);
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
 /**
  * @constructor
- * @param {!WebInspector.MemoryStatistics} memoryCountersPane
- * @param {string} title
  * @param {string} graphColor
- * @param {!WebInspector.MemoryStatistics.Counter} counter
+ * @param {!WebInspector.Counter} counter
  */
-WebInspector.CounterUIBase = function(memoryCountersPane, title, graphColor, counter)
+WebInspector.CounterUIBase = function(graphColor, counter)
 {
-    this._memoryCountersPane = memoryCountersPane;
     this.counter = counter;
-    var container = memoryCountersPane.sidebarElement().createChild("div", "memory-counter-sidebar-info");
-    var swatchColor = graphColor;
-    this._swatch = new WebInspector.SwatchCheckbox(WebInspector.UIString(title), swatchColor);
-    this._swatch.addEventListener(WebInspector.SwatchCheckbox.Events.Changed, this._toggleCounterGraph.bind(this));
-    container.appendChild(this._swatch.element);
-
-    this._value = null;
     this.graphColor = graphColor;
     this.strokeColor = graphColor;
     this.graphYValues = [];
-}
+    this._value = null;
+    this._marker = null;
+},
 
 WebInspector.CounterUIBase.prototype = {
-    _toggleCounterGraph: function(event)
-    {
-        this._value.classList.toggle("hidden", !this._swatch.checked);
-        this._memoryCountersPane.refresh();
-    },
-
     /**
      * @param {number} x
      * @return {number}
      */
     _recordIndexAt: function(x)
     {
         return this.counter.x.upperBound(x, null, this.counter._minimumIndex + 1, this.counter._maximumIndex + 1) - 1;
     },
 
     /**
@@ skipping 10 matching lines @@
         this._marker.style.top = y + "px";
         this._marker.classList.remove("hidden");
     },
 
     clearCurrentValueAndMarker: function()
     {
         this._value.textContent = "";
         this._marker.classList.add("hidden");
     },
 
+    get visible() {
+        return true;
+    },
+}
+
+/**
+ * @constructor
+ * @param {!WebInspector.MemoryStatistics} memoryCountersPane
+ * @param {string} title
+ * @param {string} graphColor
+ * @param {!WebInspector.Counter} counter
+ */
+WebInspector.MemoryCounterUIBase = function(memoryCountersPane, title, graphColor, counter)
+{
+    WebInspector.CounterUIBase.call(this, graphColor, counter);
+    this._memoryCountersPane = memoryCountersPane;
+    var container = memoryCountersPane.sidebarElement().createChild("div", "memory-counter-sidebar-info");
+    var swatchColor = graphColor;
+    this._swatch = new WebInspector.SwatchCheckbox(WebInspector.UIString(title), swatchColor);
+    this._swatch.addEventListener(WebInspector.SwatchCheckbox.Events.Changed, this._toggleCounterGraph.bind(this));
+    container.appendChild(this._swatch.element);
+}
+
+WebInspector.MemoryCounterUIBase.prototype = {
+    _toggleCounterGraph: function(event)
+    {
+        this._value.classList.toggle("hidden", !this._swatch.checked);
+        this._memoryCountersPane.refresh();
+    },
+
     get visible()
     {
         return this._swatch.checked;
     },
+
+    __proto__: WebInspector.CounterUIBase.prototype
 }
 
 WebInspector.MemoryStatistics.prototype = {
     _createCurrentValuesBar: function()
     {
         throw new Error("Not implemented");
     },
 
     createAllCounters: function()
     {
@@ skipping 176 matching lines @@
 
     /**
      * @param {?WebInspector.TimelineModel.Record} record
      */
     setSelectedRecord: function(record)
     {
     },
 
     __proto__: WebInspector.SplitView.prototype
 }