Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965203002: [MD settings] i18n-content to $i18n in passwords_and_forms (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] i18n-content to $i18n in passwords_and_forms This CL converts usage of i18n-content to $i18n. BUG=546836 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fa36c4473b9ad8486fc24fe1fd74e1e1857d582d Cr-Commit-Position: refs/heads/master@{#393096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dschuyler
4 years, 7 months ago (2016-05-11 00:30:32 UTC) #3
michaelpg
lgtm
4 years, 7 months ago (2016-05-11 22:39:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965203002/1
4 years, 7 months ago (2016-05-11 22:42:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 22:57:19 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 22:58:59 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fa36c4473b9ad8486fc24fe1fd74e1e1857d582d
Cr-Commit-Position: refs/heads/master@{#393096}

Powered by Google App Engine
This is Rietveld 408576698