Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1965183002: Unship V8 custom Promise methods (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
adamk
CC:
Michael Hablich, rossberg, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unship V8 custom Promise methods The data from UseCounters are in--V8's custom Promise methods are not in wide use on the web (<.002%). Therefore, this patch removes them. That includes: - Promise.prototype.chain - Promise.defer -- the most widely used of the bunch - Promise.accept For now, those methods are still available by checking the "disable latest stable JavaScript features" flag, or --promise-extra at the command line, but I expect them to be fully removable. R=adamk CC=rossberg BUG=v8:3238, v8:4633 Committed: https://crrev.com/fa160602a3b6703df1444d3bc463b60859b0f63e Cr-Commit-Position: refs/heads/master@{#36152}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965183002/1
4 years, 7 months ago (2016-05-11 00:12:49 UTC) #2
Dan Ehrenberg
4 years, 7 months ago (2016-05-11 00:12:58 UTC) #3
adamk
lgtm
4 years, 7 months ago (2016-05-11 00:26:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965183002/20001
4 years, 7 months ago (2016-05-11 00:32:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 01:00:32 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 01:01:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa160602a3b6703df1444d3bc463b60859b0f63e
Cr-Commit-Position: refs/heads/master@{#36152}

Powered by Google App Engine
This is Rietveld 408576698