Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1965153002: Disable WebUSB chooser service on chrome extension (Closed)

Created:
4 years, 7 months ago by juncai
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebUSB chooser service on chrome extension This patch added code to disable WebUSB chooser service on chrome extensions and apps. BUG=610880 Committed: https://crrev.com/a7770247c95f6d015763f346123e5fe32702e7ac Cr-Commit-Position: refs/heads/master@{#392808}

Patch Set 1 : disable WebUSB chooser service on chrome extension #

Patch Set 2 : check it from ChromeContentBrowserClient::RegisterRenderFrameMojoServices #

Patch Set 3 : removed redundant include file #

Total comments: 2

Patch Set 4 : address reillyg@'s comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
juncai
Please take a look.
4 years, 7 months ago (2016-05-10 23:37:41 UTC) #2
juncai
Made some changes.
4 years, 7 months ago (2016-05-11 00:01:40 UTC) #3
Reilly Grant (use Gerrit)
lgtm with nit https://codereview.chromium.org/1965153002/diff/40001/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/1965153002/diff/40001/chrome/browser/chrome_content_browser_client.cc#newcode2778 chrome/browser/chrome_content_browser_client.cc:2778: // extension. Make this a separate ...
4 years, 7 months ago (2016-05-11 00:22:44 UTC) #4
juncai
https://codereview.chromium.org/1965153002/diff/40001/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/1965153002/diff/40001/chrome/browser/chrome_content_browser_client.cc#newcode2778 chrome/browser/chrome_content_browser_client.cc:2778: // extension. On 2016/05/11 00:22:44, Reilly Grant wrote: > ...
4 years, 7 months ago (2016-05-11 00:32:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965153002/60001
4 years, 7 months ago (2016-05-11 01:00:44 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-11 01:31:10 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 01:32:22 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a7770247c95f6d015763f346123e5fe32702e7ac
Cr-Commit-Position: refs/heads/master@{#392808}

Powered by Google App Engine
This is Rietveld 408576698