Don't omit frame pointers in profiling GN builds.

Don't omit frame pointers in profiling Android GN builds.

This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:

1. Don't add -fomit-frame-pointer flag (Android-specific change).

2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
   for Android where debug builds are optimized too (-Os).

BUG=602701
Committed: https://crrev.com/14430a4de781aca8e67f6ec7b8893647d7ee26d9
Cr-Commit-Position: refs/heads/master@{#393320}

[Dmitry Skiba, 2016-05-11 21:56:19]

dskiba@google.com changed reviewers:
+ dpranke@chromium.org

[Dmitry Skiba, 2016-05-11 21:56:19]

Detailed data:

=== Debug / no profiling ===

GYP:    -fno-omit-frame-pointer - 0 matches
        -fomit-frame-pointer - 1208 matches across 1205 files

GN:     -fno-omit-frame-pointer - 0 matches
        -fomit-frame-pointer - 1302 matches across 1299 files

Patched GN: -fno-omit-frame-pointer - 0 matches
            -fomit-frame-pointer - 1302 matches across 1299 files

=== Debug / profiling ===

GYP:    -fno-omit-frame-pointer - 0 matches
        -fomit-frame-pointer - 46 matches across 46 files
            (only in obj.host folders, e.g.
out/Debug/obj.host/v8/src/v8_base.ninja)

GN:     -fno-omit-frame-pointer - 0 matches
        -fomit-frame-pointer - 1302 matches across 1299 files

Patched GN: -fno-omit-frame-pointer - 0 matches
            -fomit-frame-pointer - 3 matches across 2 files
                out-gn/Debug/obj/skia/skia_opts.ninja
                out-gn/Debug/obj/third_party/ffmpeg/ffmpeg_internal.ninja
                    (specifies -fomit-frame-pointer twice)


=== Release / no profiling ===

GYP:    -fno-omit-frame-pointer - 0 matches
        -fomit-frame-pointer - 1208 matches across 1205 files

GN:     -fno-omit-frame-pointer - 0 matches
        -fomit-frame-pointer - 1302 matches across 1299 files

Patched GN: -fno-omit-frame-pointer - 0 matches
            -fomit-frame-pointer - 1302 matches across 1299 files

=== Release / profiling ===

GYP:    -fno-omit-frame-pointer - 1203 matches across 1203 files
        -fomit-frame-pointer - 46 matches across 46 files
            (only in obj.host folders)

GN:     -fno-omit-frame-pointer - 1382 matches across 1376 files
        -fomit-frame-pointer - 1302 matches across 1299 files

        -fno-omit-frame-pointer.*-fomit-frame-pointer - 1299 matches across 1299
files
            (i.e. they are specified both, and no-omit has no effect)

Patched GN: -fno-omit-frame-pointer - 1382 matches across 1376 files
            -fomit-frame-pointer - 3 matches across 2 files
                out-gn/Release/obj/skia/skia_opts.ninja
                out-gn/Release/obj/third_party/ffmpeg/ffmpeg_internal.ninja
                    (specifies -fomit-frame-pointer twice)

[Dmitry Skiba, 2016-05-11 22:13:18]

Description was changed from

==========
Don't omit frame pointers in profiling GN builds.

This change prevents -fomit-frame-pointer cflag from being added
when enable_profiling is true. This is how GYP was behaving and
makes enable_profiling match its description:
"
Compile in such a way as to enable profiling of the generated code.
For example, don't omit the frame pointer and leave in symbols.
"

BUG=602701
==========

to

==========
Don't omit frame pointers in profiling Android GN builds.

This change prevents -fomit-frame-pointer cflag from being added
when enable_profiling is true. This is how GYP was behaving and
makes enable_profiling match its description:
"
Compile in such a way as to enable profiling of the generated code.
For example, don't omit the frame pointer and leave in symbols.
"

BUG=602701
==========

[Dirk Pranke, 2016-05-12 01:04:28]

lgtm

[Dmitry Skiba, 2016-05-12 16:52:01]

Description was changed from

==========
Don't omit frame pointers in profiling Android GN builds.

This change prevents -fomit-frame-pointer cflag from being added
when enable_profiling is true. This is how GYP was behaving and
makes enable_profiling match its description:
"
Compile in such a way as to enable profiling of the generated code.
For example, don't omit the frame pointer and leave in symbols.
"

BUG=602701
==========

to

==========
Don't omit frame pointers in profiling Android GN builds.

This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:

1. Don't add -fomit-frame-pointer flag (Android-specific change).

2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
   for Android where debug builds are optimized too (-Os).

BUG=602701
==========

[Dmitry Skiba, 2016-05-12 16:53:34]

Please take a look again. I found that Android debug builds are optimized for
size, which inhibits frame pointers unless we ask explicitly.  I also changed
the commit message.

[Dirk Pranke, 2016-05-12 17:52:11]

still lgtm.

[Dmitry Skiba, 2016-05-12 18:02:48]

The CQ bit was checked by dskiba@google.com

[Dmitry Skiba, 2016-05-12 18:02:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1965143003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-12 18:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965143003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965143003/40001

[commit-bot: I haz the power, 2016-05-12 19:00:54]

Description was changed from

==========
Don't omit frame pointers in profiling Android GN builds.

This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:

1. Don't add -fomit-frame-pointer flag (Android-specific change).

2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
   for Android where debug builds are optimized too (-Os).

BUG=602701
==========

to

==========
Don't omit frame pointers in profiling Android GN builds.

This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:

1. Don't add -fomit-frame-pointer flag (Android-specific change).

2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
   for Android where debug builds are optimized too (-Os).

BUG=602701
==========

[commit-bot: I haz the power, 2016-05-12 19:00:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 19:03:10]

Description was changed from

==========
Don't omit frame pointers in profiling Android GN builds.

This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:

1. Don't add -fomit-frame-pointer flag (Android-specific change).

2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
   for Android where debug builds are optimized too (-Os).

BUG=602701
==========

to

==========
Don't omit frame pointers in profiling Android GN builds.

This CL makes sure that frame pointers (used for fast stack unwinding)
are not omitted when enable_profiling is true. There are two changes:

1. Don't add -fomit-frame-pointer flag (Android-specific change).

2. Add -fno-omit-frame-pointer flag even in debug builds. This is needed
   for Android where debug builds are optimized too (-Os).

BUG=602701

Committed: https://crrev.com/14430a4de781aca8e67f6ec7b8893647d7ee26d9
Cr-Commit-Position: refs/heads/master@{#393320}
==========

[commit-bot: I haz the power, 2016-05-12 19:03:11]

Patchset 3 (id:??) landed as
https://crrev.com/14430a4de781aca8e67f6ec7b8893647d7ee26d9
Cr-Commit-Position: refs/heads/master@{#393320}