Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: Source/core/xml/XSLImportRule.h

Issue 196513007: Oilpan: Reapply: Remove all the RefPtrs and most of the raw pointers to style (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix assertion for global persistents Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.cpp ('k') | Source/core/xml/XSLStyleSheet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XSLImportRule.h
diff --git a/Source/core/xml/XSLImportRule.h b/Source/core/xml/XSLImportRule.h
index 4d9a77a67e99b20370a589213ac15794b18ed2d0..3521e696d9d4ac849528c4f893207a1a7db1f76d 100644
--- a/Source/core/xml/XSLImportRule.h
+++ b/Source/core/xml/XSLImportRule.h
@@ -58,9 +58,12 @@ private:
virtual void setXSLStyleSheet(const String& href, const KURL& baseURL, const String& sheet) OVERRIDE;
+ // FIXME: Oilpan: This raw pointer is safe and has to be kept raw at this
+ // point to avoid cycles. When XSLImportRule is moved to the oilpan heap
+ // it should be a Member and be traced.
XSLStyleSheet* m_parentStyleSheet;
String m_strHref;
- RefPtr<XSLStyleSheet> m_styleSheet;
+ RefPtrWillBePersistent<XSLStyleSheet> m_styleSheet;
ResourcePtr<XSLStyleSheetResource> m_resource;
bool m_loading;
};
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.cpp ('k') | Source/core/xml/XSLStyleSheet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698