Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: Source/core/css/StyleSheetList.cpp

Issue 196513007: Oilpan: Reapply: Remove all the RefPtrs and most of the raw pointers to style (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix assertion for global persistents Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/StyleSheet.idl ('k') | Source/core/css/resolver/MatchRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StyleSheetList.cpp
diff --git a/Source/core/css/StyleSheetList.cpp b/Source/core/css/StyleSheetList.cpp
index d05babe98264d49633570f7003207ce9b8cb99c2..4581cb1d07048c0ca0f1cd2cf451dff464ef441f 100644
--- a/Source/core/css/StyleSheetList.cpp
+++ b/Source/core/css/StyleSheetList.cpp
@@ -49,6 +49,11 @@ inline const WillBeHeapVector<RefPtrWillBeMember<StyleSheet> >& StyleSheetList::
void StyleSheetList::detachFromDocument()
{
+ // FIXME: Oilpan: This is safe currently because the Document is
+ // *not* in the oilpan heap and the style engine is alive when the
+ // document dies. When the Document is in the oilpan heap, we need
+ // the StyleSheetList and the document to die together and get rid
+ // of the detachedStyleSheets.
m_detachedStyleSheets = document()->styleEngine()->styleSheetsForStyleSheetList(*m_treeScope);
m_treeScope = 0;
}
« no previous file with comments | « Source/core/css/StyleSheet.idl ('k') | Source/core/css/resolver/MatchRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698