Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1965093002: 🎾 Migrate more shared preferences to ContextUtils. (Closed)

Created:
4 years, 7 months ago by Peter Wen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, asvitkine+watch_chromium.org, dtrainor+watch-blimp_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate more shared preferences to ContextUtils. First CL for chrome/: https://codereview.chromium.org/1874423002/ This way of accessing app-wide shared preferences will be required in a follow-up presubmit CL. BUG=599284 Committed: https://crrev.com/320db57a6fbcde9610944375d677d9b848c60d5f Cr-Commit-Position: refs/heads/master@{#394408}

Patch Set 1 #

Patch Set 2 : Fix junit tests. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -93 lines) Patch
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/auth/TokenSourceImpl.java View 4 chunks +3 lines, -3 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/preferences/PreferencesUtil.java View 4 chunks +5 lines, -13 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 1 3 chunks +3 lines, -1 line 0 comments Download
M components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java View 7 chunks +7 lines, -7 lines 0 comments Download
M components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationService.java View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java View 1 10 chunks +10 lines, -10 lines 0 comments Download
M components/policy/android/java/src/org/chromium/policy/AbstractAppRestrictionsProvider.java View 4 chunks +3 lines, -8 lines 0 comments Download
M components/policy/android/junit/src/org/chromium/policy/AbstractAppRestrictionsProviderTest.java View 1 2 chunks +3 lines, -6 lines 0 comments Download
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedBridge.java View 7 chunks +8 lines, -8 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 7 chunks +7 lines, -16 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M sync/android/javatests/src/org/chromium/sync/notifier/InvalidationPreferencesTest.java View 3 chunks +2 lines, -12 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
Peter Wen
Hey Andrew, Could you take a look at this CL? After this CL I plan ...
4 years, 7 months ago (2016-05-11 14:16:58 UTC) #4
agrieve
lgtm!
4 years, 7 months ago (2016-05-11 17:57:13 UTC) #5
Peter Wen
+rkaplow - for components/variations/ OWNERS +tnagel - for components/policy/ OWNERS +tedchoc - for ui/android/ and ...
4 years, 7 months ago (2016-05-12 13:43:39 UTC) #7
Ted C
On 2016/05/12 13:43:39, Peter Wen wrote: > +rkaplow - for components/variations/ OWNERS > +tnagel - ...
4 years, 7 months ago (2016-05-12 16:42:31 UTC) #8
nyquist
lgtm
4 years, 7 months ago (2016-05-12 18:01:18 UTC) #9
Peter Wen
-tnagel OOO.
4 years, 7 months ago (2016-05-16 18:46:50 UTC) #11
Peter Wen
+pastarmovj for components/policy/ OWNERS. @rkaplow - Friendly ping for components/variations/ OWNERS. 🏃
4 years, 7 months ago (2016-05-16 18:49:38 UTC) #13
rkaplow
lgtm
4 years, 7 months ago (2016-05-16 19:22:38 UTC) #14
pastarmovj
components/policy LGTM
4 years, 7 months ago (2016-05-17 22:09:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965093002/20001
4 years, 7 months ago (2016-05-18 12:34:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/7588) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-18 12:36:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965093002/40001
4 years, 7 months ago (2016-05-18 12:56:40 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 13:52:05 UTC) #24
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:53:31 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/320db57a6fbcde9610944375d677d9b848c60d5f
Cr-Commit-Position: refs/heads/master@{#394408}

Powered by Google App Engine
This is Rietveld 408576698