Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1965083002: Update to use the latest version of the plugin package (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch version info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -271 lines) Patch
M DEPS View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 3 chunks +36 lines, -137 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 3 chunks +5 lines, -16 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/plugin/command_line_plugin.dart View 2 chunks +8 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 3 chunks +24 lines, -53 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/options_plugin.dart View 2 chunks +10 lines, -28 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
https://codereview.chromium.org/1965083002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1965083002/diff/1/DEPS#newcode65 DEPS:65: "linter_rev": "@6d3bdf09b4326a411e44ff472953edd9003bc33a", This will need to be updated after ...
4 years, 7 months ago (2016-05-10 21:26:18 UTC) #2
pquitslund
LGTM!
4 years, 7 months ago (2016-05-10 21:34:31 UTC) #3
Brian Wilkerson
Updated the version of analyzer (that has already been published) and updated the DEPS file ...
4 years, 7 months ago (2016-05-11 15:58:52 UTC) #4
pquitslund
lgtm
4 years, 7 months ago (2016-05-11 16:19:09 UTC) #5
Brian Wilkerson
4 years, 7 months ago (2016-05-11 16:54:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d87f9c09debb23c65d8bed4737bc2f53680b310b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698