content/browser/devtools/worker_devtools_manager.h - Issue 196503005: Make DevTools support for the embedded SharedWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/worker_devtools_manager.h

Issue 196503005: Make DevTools support for the embedded SharedWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix UAF bug Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/shared_worker_devtools_manager_unittest.cc ('k') | content/browser/devtools/worker_devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/worker_devtools_manager.h

diff --git a/content/browser/devtools/worker_devtools_manager.h b/content/browser/devtools/worker_devtools_manager.h

index a70f1784b5b5e4b7842758d99eaa7e45f4f77be5..73916c30fe2bd12f8acdbc47d874b7b7a6a0bc36 100644

--- a/content/browser/devtools/worker_devtools_manager.h

+++ b/content/browser/devtools/worker_devtools_manager.h

@@ -19,6 +19,7 @@ namespace content {

class DevToolsAgentHost;

// All methods are supposed to be called on the IO thread.

+// This class is not used when "enable-embedded-shared-worker" flag is set.

class WorkerDevToolsManager {

public:

typedef std::pair<int, int> WorkerId;

@@ -41,9 +42,8 @@ class WorkerDevToolsManager {

// Called on the IO thread.

// Returns true when the worker must be paused on start.

- bool WorkerCreated(

- WorkerProcessHost* process,

- const WorkerProcessHost::WorkerInstance& instance);

+ bool WorkerCreated(WorkerProcessHost* process,

+ const WorkerProcessHost::WorkerInstance& instance);

void WorkerDestroyed(WorkerProcessHost* process, int worker_route_id);

void WorkerContextStarted(WorkerProcessHost* process, int worker_route_id);