Source/modules/gamepad/WebKitGamepad.h - Issue 196503004: Share Gamepad and WebKitGamepad implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/gamepad/WebKitGamepad.h

Issue 196503004: Share Gamepad and WebKitGamepad implementation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Compiles and links Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 #ifndef WebKitGamepad_h

6 RuntimeEnabled=WebAnimationsAPI,	6 #define WebKitGamepad_h

7 ] partial interface Document {	7

8 readonly attribute Timeline timeline;	8 #include "modules/gamepad/Gamepad.h"
	eseidel 2014/03/12 20:05:49 This is presumably needed to keep the bindings gen This is presumably needed to keep the bindings generator happy? Seems we should add a comment about such? Also, I don't think we need the header guards. :) Nils Barth (inactive) 2014/03/13 08:55:46 Yup, this was for CG; agreed a comment would've be Show quoted text On 2014/03/12 20:05:49, eseidel wrote: > This is presumably needed to keep the bindings generator happy? Seems we should > add a comment about such? Yup, this was for CG; agreed a comment would've been in order. (This was just as "first look", and turned out it was abandoned.) Show quoted text > Also, I don't think we need the header guards. :) Probably safe ;)
9 };	9

	10 #endif // WebKitGamepad_h

OLD	NEW