Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1965023002: Finish https://codereview.chromium.org/1948763003 (Closed)

Created:
4 years, 7 months ago by jlebel
Modified:
4 years, 7 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finishing: https://codereview.chromium.org/1948763003 Adding DCHECK to make sure a service has been added when it has been discovered. BUG=603183 Committed: https://crrev.com/1640ea3d56ce7cfc6a4936525f8bf401d40bb1d7 Cr-Commit-Position: refs/heads/master@{#392756}

Patch Set 1 #

Patch Set 2 : Split code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jlebel
Hello Giovanni, Sorry about forgetting your comments on the previous patch.
4 years, 7 months ago (2016-05-10 19:27:03 UTC) #2
ortuno
lgtm
4 years, 7 months ago (2016-05-10 19:34:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965023002/20001
4 years, 7 months ago (2016-05-10 20:19:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 22:45:46 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 22:48:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1640ea3d56ce7cfc6a4936525f8bf401d40bb1d7
Cr-Commit-Position: refs/heads/master@{#392756}

Powered by Google App Engine
This is Rietveld 408576698