Use swipe gesture to switch between slides on Android

Use swipe gesture to switch between slides on Android

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1965013007

Committed: https://skia.googlesource.com/skia/+/40d21de8b6620d724f34bdc85af1dcb593d33fe0

[liyuqian, 2016-05-11 18:20:22]

Description was changed from

==========
Use swipe gesture to switch between slides on Android

BUG=skia:
==========

to

==========
Use swipe gesture to switch between slides on Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-05-11 18:24:29]

Description was changed from

==========
Use swipe gesture to switch between slides on Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use swipe gesture to switch between slides on Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-05-11 18:24:29]

liyuqian@google.com changed reviewers:
+ djsollen@google.com, jvanverth@google.com

[liyuqian, 2016-05-11 18:52:45]

liyuqian@google.com changed reviewers:
+ egdaniel@google.com

[liyuqian, 2016-05-11 18:52:46]

tldr: problem fixed by just remove window->onResize which happens to be never
called by the previous native app.

The details below are going to be a little emotional due to the 2-day torture of
this issue...

After a lot of inspections and random tries in all kinds of directions, finally
I realized that there's one big difference between our new buggy surface-based
app and the old full-window app: although the old app tries to call
window->onResize, but it never ended up being called.

So I removed this call from my new app, and everything is working nicely. This
is like walking all over the world to search for gold and finally realized that
it's just 1 meter away from the starting point... Anyway, it's still an exciting
moment for me, like defeating a video-game boss after a 2-day-long battle :D

Later, Greg pointed out that Android may not implement the swapchain to resize
window yet. That's why all kinds of weird things happened...

Finally, I removed the postInvalidate call because my inspections told me that
the SurfaceView is entirely drawn by the native thread (our thread), not Android
thread.

[djsollen, 2016-05-11 19:05:25]

https://codereview.chromium.org/1965013007/diff/20001/platform_tools/android/...
File
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java
(right):

https://codereview.chromium.org/1965013007/diff/20001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java:22:
extends Activity implements SurfaceHolder.Callback, View.OnTouchListener {
this line should be indented by 8 spaces since it is a continuation of the
previous line

https://codereview.chromium.org/1965013007/diff/20001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java:46:
Log.d("test", "fling right, velocity = " + velocityX);
remove the logging

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/Window_android.cpp (right):

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.cpp:30: const DisplayParams&
Window_android::getDisplayParams() {
what is the motivation behind this?

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:30: {{AKEYCODE_SOFT_LEFT,
Window::Key::kLeft}, {AKEYCODE_SOFT_RIGHT, Window::Key::kRight}});
order these with one per line so that they are easier to read.

[liyuqian, 2016-05-11 19:11:24]

Revised.

https://codereview.chromium.org/1965013007/diff/20001/platform_tools/android/...
File
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java
(right):

https://codereview.chromium.org/1965013007/diff/20001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java:22:
extends Activity implements SurfaceHolder.Callback, View.OnTouchListener {
On 2016/05/11 19:05:25, djsollen wrote:
> this line should be indented by 8 spaces since it is a continuation of the
> previous line

Done.

https://codereview.chromium.org/1965013007/diff/20001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java:46:
Log.d("test", "fling right, velocity = " + velocityX);
On 2016/05/11 19:05:25, djsollen wrote:
> remove the logging

Done.

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/Window_android.cpp (right):

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.cpp:30: const DisplayParams&
Window_android::getDisplayParams() {
On 2016/05/11 19:05:25, djsollen wrote:
> what is the motivation behind this?

If I don't check fWindowContext, there will be segmentation fault when
fWindowContext is NULL.

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1965013007/diff/20001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:30: {{AKEYCODE_SOFT_LEFT,
Window::Key::kLeft}, {AKEYCODE_SOFT_RIGHT, Window::Key::kRight}});
On 2016/05/11 19:05:25, djsollen wrote:
> order these with one per line so that they are easier to read.

Done.

[djsollen, 2016-05-12 15:55:20]

lgtm

[liyuqian, 2016-05-12 15:55:47]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-05-12 15:55:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965013007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965013007/40001

[commit-bot: I haz the power, 2016-05-12 16:17:07]

Description was changed from

==========
Use swipe gesture to switch between slides on Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use swipe gesture to switch between slides on Android

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/40d21de8b6620d724f34bdc85af1dcb593d33fe0
==========

[commit-bot: I haz the power, 2016-05-12 16:17:08]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/40d21de8b6620d724f34bdc85af1dcb593d33fe0