src/frames.cc - Issue 1965013005: [turbofan] Slighly improve JSCreateArguments lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 1965013005: [turbofan] Slighly improve JSCreateArguments lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment. Fix control input. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index fc26168114d540eda866c6872485f28bdc245cc0..a8fe6bb7b61b2524c6f84313370ab665b234424e 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -1164,7 +1164,8 @@ void OptimizedFrame::GetFunctions(List<JSFunction*>* functions) const {

DisallowHeapAllocation no_gc;

int deopt_index = Safepoint::kNoDeoptimizationIndex;

DeoptimizationInputData* const data = GetDeoptimizationData(&deopt_index);

- DCHECK(data != nullptr && deopt_index != Safepoint::kNoDeoptimizationIndex);

+ DCHECK_NOT_NULL(data);

+ DCHECK_NE(Safepoint::kNoDeoptimizationIndex, deopt_index);

FixedArray* const literal_array = data->LiteralArray();

TranslationIterator it(data->TranslationByteArray(),

« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/runtime/runtime-scopes.cc » ('j') | no next file with comments »