Chromium Code Reviews| Index: src/compiler/js-create-lowering.cc |
| diff --git a/src/compiler/js-create-lowering.cc b/src/compiler/js-create-lowering.cc |
| index 7e589ea5899198490898081078ff6b1045123ff9..1a95f9ac0392f557abf219d44e497197a00b92ae 100644 |
| --- a/src/compiler/js-create-lowering.cc |
| +++ b/src/compiler/js-create-lowering.cc |
| @@ -293,38 +293,38 @@ Reduction JSCreateLowering::ReduceJSCreateArguments(Node* node) { |
| shared_info->has_duplicate_parameters()) { |
| return NoChange(); |
| } |
| - // TODO(bmeurer): Actually we don't need a frame state here. |
| Callable callable = CodeFactory::FastNewSloppyArguments(isolate()); |
| CallDescriptor* desc = Linkage::GetStubCallDescriptor( |
| isolate(), graph()->zone(), callable.descriptor(), 0, |
| - CallDescriptor::kNeedsFrameState); |
| + CallDescriptor::kNoFlags); |
| const Operator* new_op = common()->Call(desc); |
| Node* stub_code = jsgraph()->HeapConstant(callable.code()); |
| node->InsertInput(graph()->zone(), 0, stub_code); |
| + node->RemoveInput(3); |
|
Jarin
2016/05/11 04:45:27
Could you say in the comment that you are removing
Benedikt Meurer
2016/05/11 05:37:48
Done.
|
| NodeProperties::ChangeOp(node, new_op); |
| return Changed(node); |
| } |
| case CreateArgumentsType::kUnmappedArguments: { |
| - // TODO(bmeurer): Actually we don't need a frame state here. |
| Callable callable = CodeFactory::FastNewStrictArguments(isolate()); |
| CallDescriptor* desc = Linkage::GetStubCallDescriptor( |
| isolate(), graph()->zone(), callable.descriptor(), 0, |
| - CallDescriptor::kNeedsFrameState); |
| + CallDescriptor::kNoFlags); |
| const Operator* new_op = common()->Call(desc); |
| Node* stub_code = jsgraph()->HeapConstant(callable.code()); |
| node->InsertInput(graph()->zone(), 0, stub_code); |
| + node->RemoveInput(3); |
| NodeProperties::ChangeOp(node, new_op); |
| return Changed(node); |
| } |
| case CreateArgumentsType::kRestParameter: { |
| - // TODO(bmeurer): Actually we don't need a frame state here. |
| Callable callable = CodeFactory::FastNewRestParameter(isolate()); |
| CallDescriptor* desc = Linkage::GetStubCallDescriptor( |
| isolate(), graph()->zone(), callable.descriptor(), 0, |
| - CallDescriptor::kNeedsFrameState); |
| + CallDescriptor::kNoFlags); |
| const Operator* new_op = common()->Call(desc); |
| Node* stub_code = jsgraph()->HeapConstant(callable.code()); |
| node->InsertInput(graph()->zone(), 0, stub_code); |
| + node->RemoveInput(3); |
| NodeProperties::ChangeOp(node, new_op); |
| return Changed(node); |
| } |