[turbofan] Slighly improve JSCreateArguments lowering.

[turbofan] Slighly improve JSCreateArguments lowering.

Make JSCreateArguments eliminatable, and remove the need for frame
states on JSCreateArguments nodes being lowered to (optimized) stub
calls. Only the runtime fallback needs a frame state, because in that
case we need to ask the deoptimizer for arguments to inlined functions.

R=jarin@chromium.org

Committed: https://crrev.com/2301473a88ac3148c14ccc44b73af2763db2cede
Cr-Commit-Position: refs/heads/master@{#36154}

[Benedikt Meurer, 2016-05-11 04:19:01]

Hey Jaro,

Easy stuff.
Please take a look.

Thanks,
Benedikt

[Jarin, 2016-05-11 04:45:27]

lgtm (once the test redness is addressed).

https://codereview.chromium.org/1965013005/diff/1/src/compiler/js-create-lowe...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/1965013005/diff/1/src/compiler/js-create-lowe...
src/compiler/js-create-lowering.cc:303: node->RemoveInput(3);
Could you say in the comment that you are removing frame state? (Here and
below.)

[Benedikt Meurer, 2016-05-11 05:37:48]

https://codereview.chromium.org/1965013005/diff/1/src/compiler/js-create-lowe...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/1965013005/diff/1/src/compiler/js-create-lowe...
src/compiler/js-create-lowering.cc:303: node->RemoveInput(3);
On 2016/05/11 04:45:27, Jarin wrote:
> Could you say in the comment that you are removing frame state? (Here and
> below.)

Done.

[Benedikt Meurer, 2016-05-11 05:38:28]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-05-11 05:38:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1965013005/#ps40001
(title: "Address comment. Fix control input.")

[commit-bot: I haz the power, 2016-05-11 05:38:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965013005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965013005/40001

[commit-bot: I haz the power, 2016-05-11 06:10:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-11 06:12:07]

Description was changed from

==========
[turbofan] Slighly improve JSCreateArguments lowering.

Make JSCreateArguments eliminatable, and remove the need for frame
states on JSCreateArguments nodes being lowered to (optimized) stub
calls. Only the runtime fallback needs a frame state, because in that
case we need to ask the deoptimizer for arguments to inlined functions.

R=jarin@chromium.org
==========

to

==========
[turbofan] Slighly improve JSCreateArguments lowering.

Make JSCreateArguments eliminatable, and remove the need for frame
states on JSCreateArguments nodes being lowered to (optimized) stub
calls. Only the runtime fallback needs a frame state, because in that
case we need to ask the deoptimizer for arguments to inlined functions.

R=jarin@chromium.org

Committed: https://crrev.com/2301473a88ac3148c14ccc44b73af2763db2cede
Cr-Commit-Position: refs/heads/master@{#36154}
==========

[commit-bot: I haz the power, 2016-05-11 06:12:07]

Patchset 3 (id:??) landed as
https://crrev.com/2301473a88ac3148c14ccc44b73af2763db2cede
Cr-Commit-Position: refs/heads/master@{#36154}